feat(cli): create workspace using parameters from existing workspace #10604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Nov 9, 2023
| template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, version.ID) | ||
|
|
||
| // Firstly, create a regular workspace using template with parameters. | ||
| inv, root := clitest.New(t, "create", "my-workspace", "--template", template.Name, "-y", |
There was a problem hiding this comment.
NB: we now have dbfake.WorkspaceWithAgent if you want to speed things up
There was a problem hiding this comment.
WorkspaceWithAgent looks efficient, but I need a workspace with build parameters and a corresponding template with rich parameters. Not sure if the function supports it.
johnstcn
approved these changes
Nov 9, 2023
|
May be we should call it We can put a disclaimer that it only copies the parameters and not the data stored in persisted resources. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9923
This PR adds support for duplicating workspace using CLI. It is implemented as part of the
coder createcommand according to this design (thanks @Parkreiner!).