Skip to content

refactor(cli): extract workspace list parameters #10605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

refactor(cli): extract workspace list parameters #10605

merged 1 commit into from
Nov 9, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Nov 9, 2023

In support of #10428: extracts the --search and --all parameters to a separate struct in cliui.

@johnstcn johnstcn requested review from mafredri and mtojek November 9, 2023 11:46
@johnstcn johnstcn self-assigned this Nov 9, 2023
mtojek
mtojek approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@johnstcn johnstcn merged commit 8a7f0e9 into main Nov 9, 2023
@johnstcn johnstcn deleted the cj/refactor-cliui-filter branch November 9, 2023 12:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mtojek