fix: add missing focus state styling to buttons and checkboxes #10614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
commented
Nov 9, 2023
| * make the styling more obvious, even if there's not much room for | ||
| * customization). | ||
| */ | ||
| "&.Mui-focusVisible": { |
There was a problem hiding this comment.
Long comment, but trying all these selectors and seeing what exactly was happening is the reason this PR took so long. Wanted to try preventing other people from going down this rabbit hole
|
That's super nice. Will improve the accessibility for sure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9855 and adds a couple of other changes, too.
Changes made
There might be some other components that need similar updates, but this should help keyboard navigation in the site a lot.