Skip to content

fix: types-generated.ts #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2022
Merged

fix: types-generated.ts #1063

merged 1 commit into from
Apr 19, 2022

Conversation

greyscaled
Copy link
Contributor

@greyscaled greyscaled commented Apr 19, 2022

#1047 had inconsistent CI results in the PR vs as a commit in master. Opening this after running make apitypings/generate in my workspace to see if we can fix the situation or at least spot an inconsistency if there really is one.

cc @f0ssel and @kylecarbs

@greyscaled greyscaled requested a review from a team as a code owner April 19, 2022 01:37
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1063 (9b75f13) into main (f46b4cf) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1063      +/-   ##
==========================================
- Coverage   66.71%   66.70%   -0.01%     
==========================================
  Files         261      261              
  Lines       15502    15502              
  Branches      152      152              
==========================================
- Hits        10342    10341       -1     
- Misses       4112     4114       +2     
+ Partials     1048     1047       -1     
Flag Coverage Δ
unittest-go-macos-latest 53.32% <ø> (-0.07%) ⬇️
unittest-go-postgres- 65.91% <ø> (-0.08%) ⬇️
unittest-go-ubuntu-latest 55.84% <ø> (+0.07%) ⬆️
unittest-go-windows-2022 52.78% <ø> (-0.07%) ⬇️
unittest-js 67.96% <ø> (ø)
Impacted Files Coverage Δ
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
provisionersdk/transport.go 78.72% <0.00%> (-6.39%) ⬇️
codersdk/provisionerdaemons.go 59.70% <0.00%> (-5.98%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
agent/agent.go 64.42% <0.00%> (-1.45%) ⬇️
coderd/provisionerdaemons.go 59.86% <0.00%> (ø)
provisionerd/provisionerd.go 79.55% <0.00%> (+0.14%) ⬆️
peer/conn.go 80.45% <0.00%> (+1.26%) ⬆️
cli/cliui/provisionerjob.go 78.57% <0.00%> (+2.14%) ⬆️
coderd/workspaceagents.go 62.59% <0.00%> (+2.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46b4cf...9b75f13. Read the comment docs.

@greyscaled greyscaled merged commit 118a47e into main Apr 19, 2022
@greyscaled greyscaled deleted the vapurrmaid/fix branch April 19, 2022 02:03
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants