Skip to content

fix: handle SIGHUP from OpenSSH #10638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fix: handle SIGHUP from OpenSSH #10638

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4531089
Fix coder ssh to handle SIGHUP from OpenSSH
spikecurtis Nov 9, 2023
2b943ba
buffer chan so goroutine doesn't block
spikecurtis Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
buffer chan so goroutine doesn't block
  • Loading branch information
@spikecurtis
spikecurtis authored Nov 13, 2023
commit 2b943ba56fc1909824a5da3c63444155cf057dcc
2 changes: 1 addition & 1 deletion cli/ssh_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ func TestSSH(t *testing.T) {
})

// accept a single connection
msgs := make(chan string)
msgs := make(chan string, 1)
go func() {
conn, err := l.Accept()
if !assert.NoError(t, err) {
Expand Down