feat: Add Azure instance identitity authentication #1064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables zero-trust authentication for Azure instances. Now we support the three major clouds: AWS, Azure, and GCP 😎.
Codecov Report
@@ Coverage Diff @@
## main #1064 +/- ##
==========================================
+ Coverage 66.59% 66.67% +0.08%
==========================================
Files 261 262 +1
Lines 15502 15653 +151
Branches 152 152
==========================================
+ Hits 10323 10437 +114
- Misses 4127 4150 +23
- Partials 1052 1066 +14
Continue to review full report at Codecov.
|
johnstcn
approved these changes
Apr 19, 2022
| @@ -24,6 +25,7 @@ import ( | |||
| "time" | |||
|
|
|||
| "cloud.google.com/go/compute/metadata" | |||
| "github.com/fullsailor/pkcs7" | |||
There was a problem hiding this comment.
Suggest using github.com/mozilla-services/pkcs7 as it appears to be more up-to-date.
| workspace := coderdtest.CreateWorkspace(t, client, codersdk.Me, template.ID) | ||
| coderdtest.AwaitWorkspaceBuildJob(t, client, workspace.LatestBuild.ID) | ||
|
|
||
| cmd, _ := clitest.New(t, "agent", "--auth", "azure-instance-identity", "--url", client.URL.String()) |
| }, &http.Client{ | ||
| Transport: roundTripper(func(r *http.Request) (*http.Response, error) { | ||
| // Only handle metadata server requests. | ||
| if r.URL.Host != "169.254.169.254" { |
| Header: make(http.Header), | ||
| }, nil | ||
| default: | ||
| panic("unhandled route: " + r.URL.Path) |
There was a problem hiding this comment.
(comment): I'm always divided on panicking in test code versus just calling t.Fatalf with the error. I guess panic is way more explicit and should never happen in this case :-)
There was a problem hiding this comment.
I'm honestly fine with either. If you have a preference, I'm happy to take it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables zero-trust authentication for Azure instances. Now
we support the three major clouds: AWS, Azure, and GCP 😎.