Skip to content

refactor(site): use generated Healthcheck API entities #10650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 13, 2023
Merged

refactor(site): use generated Healthcheck API entities #10650

merged 5 commits into from
Nov 13, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Nov 13, 2023 •
edited
Loading

Extracted from: #10620

This PR adjusts the Healthcheck page's code to use generated API entities instead of maps or anys. There was a tiny misconfiguration in the apitypings script, which skipped the derphealth model.

@mtojek mtojek self-assigned this Nov 13, 2023
@mtojek mtojek changed the title refactor(site): use Healthcheck API entities refactor(site): use generated Healthcheck API entities Nov 13, 2023
@mtojek mtojek marked this pull request as ready for review November 13, 2023 13:35
@mtojek mtojek requested a review from BrunoQuaresma November 13, 2023 13:36
@mtojek mtojek mentioned this pull request Nov 13, 2023
Closed
BrunoQuaresma
BrunoQuaresma approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@mtojek mtojek merged commit fbd3413 into main Nov 13, 2023
@mtojek mtojek deleted the 9470-use-healthcheck-api branch November 13, 2023 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @BrunoQuaresma