feat: add orphan option to workspace delete in UI
#10654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
approved these changes
Nov 13, 2023
site/src/pages/WorkspacePage/WorkspaceDeleteDialog/WorkspaceDeleteDialog.stories.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/WorkspacePage/WorkspaceDeleteDialog/WorkspaceDeleteDialog.tsx
Outdated
Show resolved
Hide resolved
site/src/pages/WorkspacePage/WorkspaceDeleteDialog/WorkspaceDeleteDialog.tsx
Show resolved
Hide resolved
site/src/pages/WorkspacePage/WorkspaceDeleteDialog/WorkspaceDeleteDialog.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/3eb09cc6477740ee86572c98916fa8cc?sid=da58b228-9908-4a32-982e-a7413522697c
WorkspaceDeleteDialogcomponent. Spent some time trying to genericize our existingDeleteDialogbut ultimately could not type narrow enough and realized there was a better path forward.DeleteDialogis already an abstraction ofConfirmDialog. Going forward we should consider adding a component for the text validation portion of theDeleteDialog, then refactor such that separate entities have their own flavors of delete dialogs as there's a lot of distinct visual elements depending on the entity.