Skip to content

chore: clarify namespace requirement for kubernetes template #10657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2023
Merged

chore: clarify namespace requirement for kubernetes template #10657

merged 2 commits into from
Nov 14, 2023

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Nov 13, 2023

No description provided.

@bpmct bpmct added the hotfix label Nov 13, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Nov 13, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@bpmct bpmct requested a review from matifali November 13, 2023 16:57
matifali
matifali approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matifali
Copy link
Member

You need to run make fmt @bpmct

@matifali matifali enabled auto-merge (squash) November 14, 2023 21:20
@matifali matifali merged commit f3ffcba into main Nov 14, 2023
@matifali matifali deleted the k8s-copy branch November 14, 2023 21:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@bpmct bpmct

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpmct @matifali