feat(coderd): add parameter to force health check in /debug/health #10677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4029aed to
0b8e032
Compare
mtojek
reviewed
Nov 15, 2023
|
|
||
| // Get cached report if it exists and the requester did not force a refresh. | ||
| if !forced { | ||
| if report := api.healthCheckCache.Load(); report != nil { |
There was a problem hiding this comment.
Do we need an extra safety check to ensure that only 1 request is in-flight?
There was a problem hiding this comment.
I belive the healthcheck singleflight group should take care of that.
| formatHealthcheck(ctx, rw, r, report) | ||
| return | ||
| // Check if the forced query parameter is set. | ||
| forced := r.URL.Query().Get("force") == "true" |
There was a problem hiding this comment.
I get the invalidation concept, but if it does not take too much time, maybe we can also run the health check without caching?
There was a problem hiding this comment.
if it does not take too much time
I think this is a pretty big 'if' :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8969
Modifies the
/debug/healthendpoint to accept aforce=(true|_)parameter.Iff set to
true, will re-run the healthcheck immediately.UI changes will come in a separate PR.