Skip to content

fix(coderd): fix memory leak in watchWorkspaceAgentMetadata #10685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2023
Merged

fix(coderd): fix memory leak in watchWorkspaceAgentMetadata #10685

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e6ad02f
fix(coderd): fix memory leak in `watchWorkspaceAgentMetadata`
mafredri Nov 14, 2023
65a9899
fixes
mafredri Nov 15, 2023
ab3cea2
add test that can reproduce memory leak
mafredri Nov 15, 2023
1da56e6
remove unused testutil function
mafredri Nov 16, 2023
5bb2a4b
break out slice set merger into appendUnique
mafredri Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused testutil function
  • Loading branch information
@mafredri
mafredri committed Nov 16, 2023
commit 1da56e69616a41c789c4612c1def64454d229aa6
22 changes: 0 additions & 22 deletions testutil/go.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package testutil

import (
"context"
"testing"
)

Expand All @@ -22,24 +21,3 @@ func Go(t *testing.T, fn func()) (done <-chan struct{}) {

return doneC
}

// GoContext runs fn in a goroutine passing a context that will be
// canceled on test completion and wait until fn has finished executing.
// Done and cancel are returned for optionally waiting until completion
// or early cancellation.
func GoContext(t *testing.T, fn func(context.Context)) (done <-chan struct{}, cancel context.CancelFunc) {
t.Helper()

ctx, cancel := context.WithCancel(context.Background())
doneC := make(chan struct{})
t.Cleanup(func() {
cancel()
<-done
})
go func() {
fn(ctx)
close(doneC)
}()

return doneC, cancel
}