feedback

coder · aslilac · Dec 4, 2023 · Nov 21, 2023 · Nov 21, 2023 · Nov 22, 2023
commit 294281c6c7c7563c9913535a97c50b6e71349877
diff --git a/site/src/pages/IconsPage/IconsPage.tsx b/site/src/pages/IconsPage/IconsPage.tsx
@@ -79,7 +79,7 @@ export const IconsPage: FC = () => {
             <Tooltip
               placement="bottom-end"
               title={
-                <div
+                <p
                   css={{
                     padding: 8,
                     fontSize: 13,
@@ -90,7 +90,7 @@ export const IconsPage: FC = () => {
                   public GitHub repository. Just keep in mind that it should be
                   relevant to many Coder users, and redistributable under a
                   permissive license.
-                </div>
+                </p>
               }
             >
               <Link href="https://github.com/coder/coder/tree/main/site/static/icon">

diff --git a/site/src/pages/TemplateSettingsPage/TemplateSchedulePage/ScheduleDialog.tsx b/site/src/pages/TemplateSettingsPage/TemplateSchedulePage/ScheduleDialog.tsx
@@ -71,7 +71,7 @@ export const ScheduleDialog: FC<PropsWithChildren<ScheduleDialogProps>> = ({
                 <div css={styles.dialogDescription}>{`
                 This change will result in ${inactiveWorkspacesToGoDormant} workspaces being immediately transitioned to the dormant state and ${inactiveWorkspacesToGoDormantInWeek} over the next seven days. To prevent this, do you want to reset the inactivity period for all template workspaces?`}</div>
                 <FormControlLabel
-                  css={{ marginTop: 2 }}
+                  css={{ marginTop: 16 }}
                   control={
                     <Checkbox
                       size="small"
@@ -90,13 +90,13 @@ export const ScheduleDialog: FC<PropsWithChildren<ScheduleDialogProps>> = ({
             <>
               <h4>Dormancy Auto-Deletion</h4>
               <Stack direction="row" spacing={5}>
-                <div css={styles.dialogDescription}>
+                <p css={styles.dialogDescription}>
                   This change will result in {dormantWorkspacesToBeDeleted}{" "}
                   workspaces being immediately deleted and{" "}
                   {dormantWorkspacesToBeDeletedInWeek} over the next 7 days. To
                   prevent this, do you want to reset the dormancy period for all
                   template workspaces?
-                </div>
+                </p>
                 <FormControlLabel
                   css={{ marginTop: 2 }}
                   control={

diff --git a/site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx b/site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx
@@ -188,7 +188,7 @@ const Form: FC<FormProps> = ({
           );
         })}
       </FormFields>
-      <div css={{ padding: "24px 8px" }}>
+      <div css={{ paddingTop: "24px", paddingBottom: "8px" }}>
         <Button
           data-testid="build-parameters-submit"
           type="submit"

diff --git a/site/src/pages/WorkspacesPage/WorkspacesButton.tsx b/site/src/pages/WorkspacesPage/WorkspacesButton.tsx
@@ -77,7 +77,8 @@ export const WorkspacesButton: FC<WorkspacesButtonProps> = ({
           css={{
             display: "flex",
             flexDirection: "column",
-            padding: "0 8px",
+            paddingTop: "8px",
+            paddingBottom: "8px",
           }}
         >
           {templatesFetchStatus === "loading" ? (
@@ -105,7 +106,6 @@ export const WorkspacesButton: FC<WorkspacesButtonProps> = ({
               display: "flex",
               alignItems: "center",
               columnGap: 12,
-
               color: theme.palette.primary.main,
             })}
           >

diff --git a/site/src/pages/WorkspacesPage/WorkspacesSearchBox.tsx b/site/src/pages/WorkspacesPage/WorkspacesSearchBox.tsx
@@ -55,7 +55,8 @@ export const SearchBox = forwardRef(function SearchBox(
           css={{
             display: "block",
             fontSize: "14px",
-            margin: "auto 0",
+            marginLeft: "auto",
+            marginRight: "auto",
             color: theme.palette.text.secondary,
           }}
         />

diff --git a/site/src/testHelpers/renderHelpers.tsx b/site/src/testHelpers/renderHelpers.tsx
@@ -120,7 +120,7 @@ type RenderHookWithAuthOptions<Props> = Partial<
  *
  * @see {@link https://github.com/coder/coder/pull/10362#discussion_r1380852725}
  */
-export async function renderHookWithAuth<Props, Result>(
+export async function renderHookWithAuth<Result, Props>(
   render: (initialProps: Props) => Result,
   options: RenderHookWithAuthOptions<Props> = {},
 ) {