Skip to content

feat!: bump workspace activity by 1 hour #10704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 15, 2023
Merged

feat!: bump workspace activity by 1 hour #10704

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7bd2123
feat: workspace activity bump by 1 hour
Emyrk Nov 14, 2023
141cba9
Never reduce the deadline
Emyrk Nov 14, 2023
c36b27d
feat: write query to adjust ttl bump
Emyrk Nov 15, 2023
b8f88a7
Implement dbmem
Emyrk Nov 15, 2023
dc84fb8
Add comment
Emyrk Nov 15, 2023
f088523
remove debug print
Emyrk Nov 15, 2023
566dd38
Fix activity bump test
Emyrk Nov 15, 2023
696d925
add tst logs
Emyrk Nov 15, 2023
f4d6c59
Try pushing to utc
Emyrk Nov 15, 2023
a8327f0
Fix log line
Emyrk Nov 15, 2023
69c6d8a
Use db time
Emyrk Nov 15, 2023
32175d8
make fmt
Emyrk Nov 15, 2023
05e11c4
Fix comments and wording
Emyrk Nov 15, 2023
3f1327b
Add logging information to unit test
Emyrk Nov 15, 2023
ceb3bd8
Remove duplicated variable
Emyrk Nov 15, 2023
4d04500
Compare unix timestamps
Emyrk Nov 15, 2023
8e3ed21
Use time.Equal
Emyrk Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Never reduce the deadline
  • Loading branch information
@Emyrk
Emyrk committed Nov 14, 2023
commit 141cba941ba831fc1a6c77c56c7575dd8527ef92
9 changes: 5 additions & 4 deletions coderd/database/queries/activitybump.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ WITH latest AS (
-- workspace auto started at the given time and the original
-- TTL was applied.
WHEN NOW() + ('60 minutes')::interval > @next_autostart :: timestamptz
-- If the autostart is behind the created_at, then the
-- If the autostart is behind now(), then the
-- autostart schedule is either the 0 time and not provided,
-- or it was the autostart in the past, which is no longer
-- relevant. If a past autostart is being passed in,
-- that is a mistake by the caller.
AND @next_autostart > workspace_builds.created_at
AND @next_autostart > NOW()
THEN
-- Extend to the autostart, then add the TTL
((@next_autostart :: timestamptz) - NOW()) + CASE
Expand Down Expand Up @@ -54,8 +54,9 @@ SET
updated_at = NOW(),
deadline = CASE
WHEN l.build_max_deadline = '0001-01-01 00:00:00+00'
THEN NOW() + l.ttl_interval
ELSE LEAST(NOW() + l.ttl_interval, l.build_max_deadline)
-- Never reduce the deadline from activity.
THEN GREATEST(wb.deadline, NOW() + l.ttl_interval)
ELSE LEAST(GREATEST(wb.deadline, NOW() + l.ttl_interval), l.build_max_deadline)
END
FROM latest l
WHERE wb.id = l.build_id
Expand Down