feat: allow autostop to be specified in minutes and seconds #10707
Conversation
| @@ -404,7 +399,7 @@ export const WorkspaceScheduleForm: FC< | |||
| <TextField | |||
| {...formHelpers("ttl", ttlShutdownAt(form.values.ttl), "ttl_ms")} | |||
| disabled={isLoading || !form.values.autostopEnabled} | |||
| inputProps={{ min: 0, step: 1 }} | |||
| inputProps={{ min: 0, step: "any" }} | |||
There was a problem hiding this comment.
Since the validator got updated to remove the integer constraint, I'm guessing the step was changed to allow floats. Just want to make sure, though: are negative and zero steps are expected here?
There was a problem hiding this comment.
@Parkreiner Good eye! Don't worry - we still validate against negative and 0 inputs here.
I am using a step of 'any' because this defaults to a step of 1 while still allowing for floats.
|
@Kira-Pilot, how do we do this from the UI? The auto stop increment/decrement only allows hours as per the latest dev.coder.com |
|
@matifali the autostop setting in the workspace schedule form accepts floats now, e.g: I will create a follow-up PR for the widget in your screenshot. |
|
@matifali after some further testing, seems like the BE isn't accepting floats, so I am going to reopen this ticket and work on it this sprint. |
resolves #10183