chore: allow process.env.PORT in webpack.dev #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1071 +/- ##
==========================================
- Coverage 66.79% 66.70% -0.09%
==========================================
Files 262 262
Lines 15653 15653
Branches 152 152
==========================================
- Hits 10456 10442 -14
- Misses 4136 4147 +11
- Partials 1061 1064 +3
Continue to review full report at Codecov.
|
kylecarbs
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a small improvement which allows you to override the port that webpack runs on using
PORTas an environment variable. Adding this because some folks use applications (aka code-server) that run on 8080.