Skip to content

feat: do not fail DERP healthcheck if WebSocket is used #10714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 17, 2023
Merged

feat: do not fail DERP healthcheck if WebSocket is used #10714

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
01cbf06
Add warnings property
mtojek Nov 15, 2023
6c84dc8
make gen
mtojek Nov 15, 2023
b66e38e
test derp
mtojek Nov 15, 2023
cec2e6d
another test
mtojek Nov 15, 2023
f1d7643
Warnings
mtojek Nov 15, 2023
98bd84c
make fmt
mtojek Nov 17, 2023
18f147a
Merge branch 'main' into 9470-warnings
mtojek Nov 17, 2023
5bc1366
one more
mtojek Nov 17, 2023
1fb7d56
TS
mtojek Nov 17, 2023
2f468fc
test fix
mtojek Nov 17, 2023
e98b9fc
one more
mtojek Nov 17, 2023
1671f5e
Better unit
mtojek Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test fix
  • Loading branch information
@mtojek
mtojek committed Nov 17, 2023
commit 2f468fcb44b9acb80f67cb8dbb18bd2e2f3fd99d
2 changes: 1 addition & 1 deletion coderd/healthcheck/derphealth/derp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ func TestDERP(t *testing.T) {

assert.False(t, report.Healthy)
for _, region := range report.Regions {
assert.False(t, region.Healthy)
assert.True(t, region.Healthy)
for _, node := range region.NodeReports {
assert.True(t, node.Healthy)
assert.True(t, node.CanExchangeMessages)
Expand Down