chore: add uuid's to ssh sessions for logging #10721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Nov 16, 2023
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging some ssh logs, it was hard to know which connections were still open. Assigning a uuid helped figure out the "life" of a sessions. It is very easy to match the "handle" and "exit" ssh log lines with the uuids.
Wish I could use context
Very annoying I could not add the logger fields to the context, but ssh context is a specific struct that embeds a
context.Context. You cannot docontext.WithValue()on it, soslog.With()cannot be used.It does have a
ctx.SetValue(), but slog's context value struct is not exported, so I cannot pass slog fields this way.