refactor(site): adjust a few colors #10750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BrunoQuaresma
commented
Nov 17, 2023
•
- Adjust text secondary color
- Adjust alert icon colors
- Adjust "active" bars in the tabs and sidebar components
- Wrap the users page tab content into a suspense avoiding load all the page instead only the content part
BrunoQuaresma
commented
Nov 17, 2023
| @@ -189,14 +189,19 @@ const StatusOptionItem = ({ | |||
| }; | |||
|
|
|||
| const StatusIndicator: FC<{ option: StatusOption }> = ({ option }) => { | |||
| const color = option.color === "notice" ? "warning" : option.color; | |||
There was a problem hiding this comment.
@aslilac I didn't figure out how to make it work with "notice" instead of "warning"
BrunoQuaresma
commented
Nov 17, 2023
| [`& .${alertClasses.icon}`]: { | ||
| color: dark.palette.error.light, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Unfortunately, MUI does not have a way to say "use light colors for icons" so I made it manually.
…r-secondary-color
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.