Skip to content

fix(site): prevent overwriting of newest workspace data during optimistic updates #10751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2023
Merged

fix(site): prevent overwriting of newest workspace data during optimistic updates #10751

merged 2 commits into from
Nov 17, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Fix #10747

@BrunoQuaresma BrunoQuaresma self-assigned this Nov 17, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Nov 17, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@BrunoQuaresma BrunoQuaresma changed the title fix(site): avoid update newest builds fix(site): fix newest workspace data being overwrite on optimistic updates Nov 17, 2023
@BrunoQuaresma BrunoQuaresma changed the title fix(site): fix newest workspace data being overwrite on optimistic updates fix(site): prevent overwriting of newest workspace data during optimistic updates Nov 17, 2023
@BrunoQuaresma BrunoQuaresma merged commit 4121121 into main Nov 17, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-flakes branch November 17, 2023 12:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e flake: start workspace with ephemeral parameters
1 participant
@BrunoQuaresma