Skip to content

refactor(site): add minor improvements to the schedule controls #10756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Screen.Recording.2023-11-17.at.10.49.31.mov

@BrunoQuaresma BrunoQuaresma requested review from aslilac and a team November 17, 2023 13:52
@BrunoQuaresma BrunoQuaresma self-assigned this Nov 17, 2023
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! Just one minor suggestion for a grammar fix while you're touching these files:

Could you change "Subtract hours to deadline" to "Subtract hours from deadline inside the DecreaseTimeContent component?

@@ -268,6 +270,7 @@ export const DecreaseTimeContent = (props: {
}}
>
<TextField
autoFocus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's only one line, this should really help the UX feel nicer. I'm a fan

@Parkreiner Parkreiner self-requested a review November 17, 2023 14:40
@BrunoQuaresma BrunoQuaresma merged commit e6f11a3 into main Nov 17, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/change-stop-string branch November 17, 2023 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants