fix: clarify language in orphan section of delete modal #10764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Kira-Pilot
commented
Nov 17, 2023
•
|
@Kira-Pilot how de we actually decide which resources to keep? And how does it work. Don't we run |
@matifali I'm not exactly sure! This is just a front-end implementation. Seems like @ammario implemented this flag; perhaps he can fill you in. |
|
Yes I did implement the original feature. It is a no-op from the terraform perspective because the point of the feature is to get rid of a workspace that's failing "terraform destroy". |
|
Oh ok. It's same as |
|
Design feedback for future iterations can be added here. |
matifali
reviewed
Nov 18, 2023
site/src/pages/WorkspacePage/WorkspaceDeleteDialog/WorkspaceDeleteDialog.tsx
Outdated
Show resolved
Hide resolved
…leteDialog.tsx Co-authored-by: Muhammad Atif Ali <atif@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.