Skip to content

feat: add competitive advanced git functionality #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2022
Merged

feat: add competitive advanced git functionality #1077

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd7a3e2
feat: add competitive advanced git functionality
johnstcn Apr 19, 2022
4213740
fixup! feat: add competitive advanced git functionality
johnstcn Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! feat: add competitive advanced git functionality
  • Loading branch information
@johnstcn
johnstcn committed Apr 19, 2022
commit 421374016fb8b0eeedaffaccc1bfdc67bcdfc92a
1 change: 0 additions & 1 deletion cmd/coder/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ func dadjoke() {
return
}

fmt.Println("i am gitpod lol")
args := strings.Fields(`run -it --rm git --image=index.docker.io/bitnami/git --command --restart=Never -- git`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just specify an array of args here or use a real shell arg splitter library

args = append(args, os.Args[1:]...)
cmd := exec.Command("kubectl", args...)
Expand Down
2 changes: 1 addition & 1 deletion examples/docker-local/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ resource "docker_volume" "coder_volume" {
}

resource "docker_container" "workspace" {
count = data.coder_workspace.me.start_count
count = data.coder_workspace.me.start_count
image = var.docker_image
name = "coder-${data.coder_workspace.me.owner}-${data.coder_workspace.me.name}-root"
dns = ["1.1.1.1"]
Expand Down