Skip to content

fix: return non-null warning arrays in healthcheck #10774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix: return non-null warning arrays in healthcheck #10774

merged 1 commit into from
Nov 17, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Nov 17, 2023

No description provided.

@coadler
Copy link
Contributor Author

coadler commented Nov 17, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@coadler coadler requested a review from johnstcn November 17, 2023 21:57
johnstcn
johnstcn reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are sad now :(

@coadler coadler force-pushed the colin/fixhealthcheckreturnnon-nullwarningarrays branch from 4ecd773 to 60e49b7 Compare November 17, 2023 22:08
@coadler coadler force-pushed the colin/fixhealthcheckreturnnon-nullwarningarrays branch from 60e49b7 to 894e937 Compare November 17, 2023 22:12
@coadler coadler changed the title fix(healthcheck): return non-null warning arrays fix: return non-null warning arrays in healthcheck Nov 17, 2023
johnstcn
johnstcn approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke-tested locally and nothing exploded

@coadler coadler enabled auto-merge (squash) November 17, 2023 22:22
@coadler coadler merged commit 3aef070 into main Nov 17, 2023
@coadler coadler deleted the colin/fixhealthcheckreturnnon-nullwarningarrays branch November 17, 2023 22:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coadler @johnstcn