Skip to content

fix(site): correctly interpret timezone based on offset in formatOffset #10797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2023
Merged

fix(site): correctly interpret timezone based on offset in formatOffset #10797

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64f7d6a
fix(site): correctly interpret timezone based on offset in `formatOff…
mafredri Nov 20, 2023
e78b211
Update site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsig…
mafredri Nov 20, 2023
215d39f
Update site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsig…
mafredri Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,14 +791,14 @@ function toISOLocal(d: Date, offset: number) {
}

function formatOffset(offset: number): string {
const isPositive = offset >= 0;
// A negative offset means that this is a positive timezone, e.g. GMT+2 = -120.
const isPositiveTimezone = offset <= 0;
const absoluteOffset = Math.abs(offset);
const hours = Math.floor(absoluteOffset / 60);
const minutes = Math.abs(offset) % 60;
const formattedHours = `${isPositive ? "+" : "-"}${String(hours).padStart(
2,
"0",
)}`;
const formattedHours = `${isPositiveTimezone ? "+" : "-"}${String(
hours,
).padStart(2, "0")}`;
const formattedMinutes = String(minutes).padStart(2, "0");
return `${formattedHours}:${formattedMinutes}`;
}