feat: disable start/restart if active version required #10809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (workspace.automatic_updates === "always") { | ||
| return "You have enabled automatic updates for this workspace"; | ||
| } | ||
| return ""; |
There was a problem hiding this comment.
I just found strange to have two places returning "" 🤔
|
Question. Do we also want to disable the secondary action on start and restart? Both actions have a secondary action that can start/restart using ephemeral parameters. It is on the button with the "dropdown icon". |
Yeah we def do, thanks ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10755
Variants:
Template Required
User opted-in
Also Restart: