fix: preserve order of node reports in healthcheck #10835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
reviewed
Nov 22, 2023
Comment on lines
504
to
505
| sorted := make([]*NodeReport, len(reports)) | ||
| copy(sorted, reports) |
There was a problem hiding this comment.
Do we need to make a copy? We're holding the mutex aren't we?
johnstcn
approved these changes
Nov 22, 2023
|
Correct. In our case, it should be stable as we don't have more than one report for nodes with the same name. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10824
The current
HealthyWithNodeDegradedtest implementation assumes that the order of node reports is stable and sorted by node name. Unfortunately, that assumption was wrong, so this PR modifies the healthcheck logic to preserve the order.