Skip to content

feat: "coder ssh --shuffle" easter egg #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2022
Merged

feat: "coder ssh --shuffle" easter egg #1084

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
176cc9d
feat: "coder ssh --shuffle" easter egg
dwahler May 9, 2022
781fab9
fix lint errors
dwahler May 9, 2022
36c50c0
Merge branch 'main' into david/easter-egg
dwahler May 9, 2022
66486d9
Merge branch 'main' into david/easter-egg
dwahler May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint errors
  • Loading branch information
@dwahler
dwahler committed May 9, 2022
commit 781fab9ce13c26748e554b406affb4efa3bd43c5
19 changes: 13 additions & 6 deletions cli/ssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package cli
import (
"context"
"io"
"math/rand"
"net"
"os"
"strings"
Expand All @@ -20,6 +19,7 @@ import (
"github.com/coder/coder/cli/cliui"
"github.com/coder/coder/coderd/database"
"github.com/coder/coder/codersdk"
"github.com/coder/coder/cryptorand"
)

func ssh() *cobra.Command {
Expand Down Expand Up @@ -52,7 +52,11 @@ func ssh() *cobra.Command {
return xerrors.New("no workspaces to shuffle")
}

workspace = workspaces[rand.Intn(len(workspaces))]
idx, err := cryptorand.Intn(len(workspaces))
if err != nil {
return err
}
workspace = workspaces[idx]
} else {
err := cobra.MinimumNArgs(1)(cmd, args)
if err != nil {
Expand Down Expand Up @@ -108,11 +112,14 @@ func ssh() *cobra.Command {
}
if agent.ID == uuid.Nil {
if len(agents) > 1 {
if shuffle {
agent = agents[rand.Intn(len(agents))]
} else {
if !shuffle {
return xerrors.New("you must specify the name of an agent")
}
idx, err := cryptorand.Intn(len(agents))
if err != nil {
return err
}
agent = agents[idx]
} else {
agent = agents[0]
}
Expand Down Expand Up @@ -191,7 +198,7 @@ func ssh() *cobra.Command {
}
cliflag.BoolVarP(cmd.Flags(), &stdio, "stdio", "", "CODER_SSH_STDIO", false, "Specifies whether to emit SSH output over stdin/stdout.")
cliflag.BoolVarP(cmd.Flags(), &shuffle, "shuffle", "", "CODER_SSH_SHUFFLE", false, "Specifies whether to choose a random workspace")
cmd.Flags().MarkHidden("shuffle")
_ = cmd.Flags().MarkHidden("shuffle")

return cmd
}
Expand Down