Skip to content

fix(docs): disable CODER_DERP_SERVER_STUN_ADDRESSES correctly #10840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix(docs): disable CODER_DERP_SERVER_STUN_ADDRESSES correctly #10840

merged 1 commit into from
Nov 22, 2023

Conversation

strike
Copy link
Contributor

@strike strike commented Nov 22, 2023

From server doc:

coder/docs/cli/server.md

Line 173 in ddf5569

Addresses for STUN servers to establish P2P connections. It's recommended to have at least two STUN servers to give users the best chance of connecting P2P to workspaces. Each STUN server will get it's own DERP region, with region IDs starting at `--derp-server-region-id + 1`. Use special value 'disable' to turn off STUN completely.

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Nov 22, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@strike strike changed the title fix(site): Disable CODER_DERP_SERVER_STUN_ADDRESSES correctly fix(docs): disable CODER_DERP_SERVER_STUN_ADDRESSES correctly Nov 22, 2023
@strike
Copy link
Contributor Author

strike commented Nov 22, 2023

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull request Nov 22, 2023
@cdrcommunity
@strike has signed the CLA in coder/coder#10840
ec2b4ec
kylecarbs
kylecarbs approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@coadler coadler merged commit 614c179 into coder:main Nov 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@strike strike

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strike @kylecarbs @coadler