Skip to content

chore(site): remove paperLight background value #10857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 27, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

I noticed we have been overusing colors in the UI, so simplifying is better for the "look and feel" and maintaining the styles over time.

image

If you want to have a better sense of what it looks like, I recommend you go to the Chromatic snapshot.

@BrunoQuaresma BrunoQuaresma requested review from aslilac and a team November 24, 2023 12:46
@BrunoQuaresma BrunoQuaresma self-assigned this Nov 24, 2023
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few comments on the stories, but other than that, I really like the changes!

Main concern was that the agents section of the Workspaces UI seemed to lose some of the obvious information hierarchy with the headers their content

@BrunoQuaresma
Copy link
Collaborator Author

BrunoQuaresma commented Nov 27, 2023

@Parkreiner interesting, for me the bg color changes made it easier to find the agents on the screen.

Screenshot 2023-11-27 at 11 48 27

Ahhh but I see you are talking about the headers 🤔 ... I see that, but I think the "bold heading" with the status circle makes them easier to distinguish. Wdyt?

@Parkreiner
Copy link
Member

One last comment

@BrunoQuaresma BrunoQuaresma merged commit a4d74b8 into main Nov 27, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/remove-extra-backgrounds branch November 27, 2023 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants