Skip to content

feat: allow auditors to read template insights #10860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2023
Merged

feat: allow auditors to read template insights #10860

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c0707a
feat: allow auditors to read template insights
johnstcn Nov 24, 2023
c434dfa
make fmt
johnstcn Nov 24, 2023
cdde0d7
address comments
johnstcn Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make fmt
  • Loading branch information
@johnstcn
johnstcn committed Nov 24, 2023
commit c434dfa2fa10e4089b07cd2cbf5a8cd23d1c7ca9
3 changes: 2 additions & 1 deletion site/src/pages/TemplatePage/TemplateLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ export const TemplateLayout: FC<{ children?: JSX.Element }> = ({
queryKey: ["template", templateName],
queryFn: () => fetchTemplate(orgId, templateName),
});
const shouldShowInsights = (data?.permissions?.canUpdateTemplate || data?.permissions?.canReadInsights);
const shouldShowInsights =
data?.permissions?.canUpdateTemplate || data?.permissions?.canReadInsights;

if (error) {
return (
Expand Down