Skip to content

chore: add Resources() to dbfake.WorkspaceBuilder #10883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: add Resources() to dbfake.WorkspaceBuilder #10883

wants to merge 1 commit into from

Conversation

spikecurtis
Copy link
Contributor

Refactor to allow directly adding resources to WorkspaceBuilder, which makes writing tests more brief.

This was referenced Nov 27, 2023
Merged
Merged
This was referenced Nov 27, 2023
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@spikecurtis spikecurtis force-pushed the spike/dbfake-shorten-names branch from cce9f6e to c7f1597 Compare November 27, 2023 08:05
@spikecurtis spikecurtis force-pushed the spike/dbfake-workspace-builder-resources branch from 96ca482 to 3439a18 Compare November 27, 2023 08:05
@spikecurtis spikecurtis force-pushed the spike/dbfake-shorten-names branch from c7f1597 to d270a5e Compare November 27, 2023 10:17
@spikecurtis spikecurtis force-pushed the spike/dbfake-workspace-builder-resources branch from 3439a18 to 2cb8562 Compare November 27, 2023 10:18
@spikecurtis spikecurtis force-pushed the spike/dbfake-shorten-names branch from d270a5e to 1623c32 Compare November 28, 2023 18:38
@spikecurtis spikecurtis force-pushed the spike/dbfake-workspace-builder-resources branch from 2cb8562 to b603527 Compare November 28, 2023 18:38
mafredri
mafredri approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Base automatically changed from spike/dbfake-shorten-names to main November 29, 2023 07:06
@spikecurtis spikecurtis force-pushed the spike/dbfake-workspace-builder-resources branch from b603527 to bd9cf12 Compare November 29, 2023 11:35
@spikecurtis spikecurtis closed this Dec 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
@github-actions github-actions bot deleted the spike/dbfake-workspace-builder-resources branch May 30, 2024 00:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@johnstcn johnstcn johnstcn approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spikecurtis @mafredri @johnstcn