Skip to content

chore: use PascalCase for pages files #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 19, 2022
Merged

chore: use PascalCase for pages files #1089

merged 9 commits into from
Apr 19, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Apr 19, 2022

This PR fixes #935

@jsjoeio jsjoeio self-assigned this Apr 19, 2022
@jsjoeio jsjoeio requested a review from a team as a code owner April 19, 2022 16:57
BrunoQuaresma
BrunoQuaresma approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsjoeio jsjoeio force-pushed the jsjoeio/refactor-pages branch from fe74598 to 0c2845f Compare April 19, 2022 17:02
@jsjoeio jsjoeio requested a review from a team April 19, 2022 17:02
@codecov
Copy link

codecov bot commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #1089 (f35b22a) into main (301451b) will decrease coverage by 0.21%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
- Coverage   66.55%   66.33%   -0.22%     
==========================================
  Files         253      252       -1     
  Lines       15661    15487     -174     
  Branches      152      152              
==========================================
- Hits        10423    10274     -149     
+ Misses       4172     4160      -12     
+ Partials     1066     1053      -13
Flag Coverage Δ
unittest-go-macos-latest 53.34% <ø> (+0.02%) ⬆️
unittest-go-postgres- 65.76% <ø> (ø)
unittest-go-ubuntu-latest 55.87% <ø> (ø)
unittest-go-windows-2022 ?
unittest-js 66.83% <22.22%> (-0.49%) ⬇️
Impacted Files Coverage Δ
site/src/AppRouter.tsx 0.00% <0.00%> (ø)
site/src/pages/404Page/404Page.tsx 0.00% <ø> (ø)
site/src/pages/CliAuthPage/CliAuthPage.tsx 0.00% <0.00%> (ø)
site/src/pages/HealthzPage/HealthzPage.tsx 0.00% <ø> (ø)
site/src/pages/OrgsPage/OrgsPage.tsx 0.00% <0.00%> (ø)
...referencesPages/AccountPage/LinkedAccountsPage.tsx 0.00% <0.00%> (ø)
...pages/PreferencesPages/AccountPage/SSHKeysPage.tsx 0.00% <0.00%> (ø)
...cesPages/LinkedAccountsPage/LinkedAccountsPage.tsx 0.00% <0.00%> (ø)
...pages/PreferencesPages/SSHKeysPage/SSHKeysPage.tsx 0.00% <0.00%> (ø)
...ges/PreferencesPages/SecurityPage/SecurityPage.tsx 0.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 301451b...f35b22a. Read the comment docs.

greyscaled
greyscaled approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM !

@jsjoeio jsjoeio force-pushed the jsjoeio/refactor-pages branch from 8f115ab to 7cbf0d3 Compare April 19, 2022 18:29
@jsjoeio jsjoeio enabled auto-merge (squash) April 19, 2022 18:30
@jsjoeio jsjoeio merged commit 98e46cd into main Apr 19, 2022
@jsjoeio jsjoeio deleted the jsjoeio/refactor-pages branch April 19, 2022 18:45
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@greyscaled greyscaled greyscaled approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Refactor pages directory
5 participants
@jsjoeio @presleyp @BrunoQuaresma @greyscaled @misskniss