Skip to content

chore: un-nest components #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2022
Merged

chore: un-nest components #1090

merged 1 commit into from
Apr 19, 2022

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Apr 19, 2022

I based off #1086 to avoid conflicts so we probably want to merge that first. rebased

@code-asher code-asher requested review from presleyp and a team as code owners April 19, 2022 18:06
@code-asher
Copy link
Member Author

code-asher commented Apr 19, 2022

One weird area is Form/utils.ts. It is used by two other forms but Form itself is not a component. moved to util

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1090 (655e9b0) into main (98e46cd) will decrease coverage by 0.15%.
The diff coverage is 85.96%.

❗ Current head 655e9b0 differs from pull request most recent head bc73e22. Consider uploading reports for the commit bc73e22 to get more accurate results

@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
- Coverage   66.53%   66.37%   -0.16%     
==========================================
  Files         255      250       -5     
  Lines       15671    15477     -194     
  Branches      152      152              
==========================================
- Hits        10426    10273     -153     
+ Misses       4180     4152      -28     
+ Partials     1065     1052      -13     
Flag Coverage Δ
unittest-go-macos-latest 53.27% <ø> (-0.08%) ⬇️
unittest-go-postgres- 65.87% <ø> (-0.03%) ⬇️
unittest-go-ubuntu-latest 55.80% <ø> (-0.06%) ⬇️
unittest-go-windows-2022 ?
unittest-js 67.32% <85.96%> (+0.48%) ⬆️
Impacted Files Coverage Δ
site/src/AppRouter.tsx 0.00% <0.00%> (ø)
site/src/app.tsx 0.00% <0.00%> (ø)
site/src/components/AuthAndFrame/AuthAndFrame.tsx 0.00% <0.00%> (ø)
site/src/components/CliAuthToken/CliAuthToken.tsx 100.00% <ø> (ø)
site/src/components/CopyButton/CopyButton.tsx 52.38% <ø> (ø)
...mponents/EnterpriseSnackbar/EnterpriseSnackbar.tsx 81.25% <ø> (ø)
site/src/components/Footer/Footer.tsx 100.00% <ø> (ø)
...src/components/FormCloseButton/FormCloseButton.tsx 100.00% <ø> (ø)
site/src/components/FormSection/FormSection.tsx 87.50% <ø> (ø)
site/src/components/FormTitle/FormTitle.tsx 100.00% <ø> (ø)
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e46cd...bc73e22. Read the comment docs.

@code-asher code-asher force-pushed the asher/unnest-components branch from 8d370ef to 45164c3 Compare April 19, 2022 18:17
Base automatically changed from bq/refactor-index to main April 19, 2022 18:20
@code-asher code-asher force-pushed the asher/unnest-components branch 2 times, most recently from d9f2c51 to 655e9b0 Compare April 19, 2022 18:38
@code-asher code-asher force-pushed the asher/unnest-components branch from 655e9b0 to bc73e22 Compare April 19, 2022 19:09
@code-asher code-asher merged commit 3151bef into main Apr 19, 2022
@code-asher code-asher deleted the asher/unnest-components branch April 19, 2022 19:16
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants