fix: insert replica when removed by cleanup #10917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Nov 28, 2023
spikecurtis
approved these changes
Nov 28, 2023
This reverts commit 71076ee.
|
Upgrading the logs to error level created new flakes in the TwentyConcurrent tests. I timeboxed trying to find the issue but couldn't find a solution to the race. You can see the failed tests in CI for more info, I've reverted that commit and will merge the rest of the changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't feel great about changing the database query because there's other things besides this loop that call it, and I don't feel those callers have the same authority about re-inserting on update. Let me know if that is not a correct assumption.
Closes #8858