example: Add Kubernetes multi-service #1092
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1092 +/- ##
==========================================
+ Coverage 66.55% 66.95% +0.40%
==========================================
Files 261 284 +23
Lines 15674 18657 +2983
Branches 152 241 +89
==========================================
+ Hits 10432 12492 +2060
- Misses 4176 4893 +717
- Partials 1066 1272 +206
Continue to review full report at Codecov.
|
|
What are your thoughts on including a PVC in this example? We can mount a PVC to multiple containers, I did it for your example here, but we loose all the nice ZSH stuff from the devcontainer |
| container { | ||
| name = "go" | ||
| image = "mcr.microsoft.com/vscode/devcontainers/go:1" | ||
| command = ["sh", "-c", coder_agent.go.init_script] |
There was a problem hiding this comment.
I've noticed all of these containers bring you to strange locations when you ssh in for the first time
go: /go
java: /
ubuntu /
Should the init script always do something like cd $HOME before it starts the agent?
There was a problem hiding this comment.
It will in my other PR now!
|
I think we'll have to do cleanup on the templates to make the names apt anyways, so I'll just leave this without volumes and such for now. |
There was a problem hiding this comment.
@kylecarbs I think this is good to go, but could you look at #1096 before merging?
* example: Add Kubernetes multi-service * fix: change to CODER_AGENT_TOKEN * example: use ServiceAccount for cluster authentication (#1096) Co-authored-by: Ben <ben@coder.com>
No description provided.