Skip to content

Conversation

kylecarbs
Copy link
Member

This was accidentally removed when adding MacOS signing.

This was accidentally removed when adding MacOS signing.
@kylecarbs kylecarbs requested a review from greyscaled April 20, 2022 13:42
@kylecarbs kylecarbs self-assigned this Apr 20, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) April 20, 2022 13:42
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1094 (3ae67c4) into main (3151bef) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
- Coverage   66.48%   66.33%   -0.15%     
==========================================
  Files         255      255              
  Lines       15671    15671              
  Branches      152      152              
==========================================
- Hits        10419    10396      -23     
- Misses       4184     4205      +21     
- Partials     1068     1070       +2     
Flag Coverage Δ
unittest-go-macos-latest 53.21% <ø> (-0.13%) ⬇️
unittest-go-postgres- 65.66% <ø> (-0.16%) ⬇️
unittest-go-ubuntu-latest 55.83% <ø> (-0.03%) ⬇️
unittest-go-windows-2022 52.84% <ø> (-0.03%) ⬇️
unittest-js 66.83% <ø> (ø)
Impacted Files Coverage Δ
peer/conn.go 77.91% <0.00%> (-2.54%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
provisionerd/provisionerd.go 77.94% <0.00%> (-1.77%) ⬇️
peer/channel.go 83.23% <0.00%> (-0.58%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (ø)
coderd/provisionerdaemons.go 59.86% <0.00%> (ø)
provisionersdk/transport.go 85.10% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3151bef...3ae67c4. Read the comment docs.

Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Nice job finding/fixing this

@kylecarbs kylecarbs merged commit 2a95917 into main Apr 20, 2022
@kylecarbs kylecarbs deleted the sitebuild branch April 20, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants