Skip to content

feat: add dismissed property to the healthcheck section #10940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 29, 2023
Merged

feat: add dismissed property to the healthcheck section #10940

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
eb4fd94
Stub for debug/health/settings
mtojek Nov 24, 2023
a820c1b
stub for HealthSettings API
mtojek Nov 24, 2023
beafecc
Merge branch 'main' into 10712-api-health-settings
mtojek Nov 27, 2023
c684b48
Merge branch 'main' into 10712-api-health-settings
mtojek Nov 28, 2023
a01878e
API
mtojek Nov 28, 2023
36b8c1c
API tests
mtojek Nov 28, 2023
7f43838
WIP
mtojek Nov 28, 2023
55e6100
Merge branch 'main' into 10712-api-health-settings-dismissed
mtojek Nov 29, 2023
29a5cda
Dismissed property
mtojek Nov 29, 2023
60a5b89
update generated
mtojek Nov 29, 2023
3c4f53a
Fix: entities.ts
mtojek Nov 29, 2023
b8f6556
link dismissed
mtojek Nov 29, 2023
6ce2d00
unit tests
mtojek Nov 29, 2023
1bf4fbf
sql.ErrNoRows
mtojek Nov 29, 2023
ec2bb2f
ErrorDismissed
mtojek Nov 29, 2023
82b991b
order
mtojek Nov 29, 2023
e9a8753
Fix
mtojek Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ErrorDismissed
  • Loading branch information
@mtojek
mtojek committed Nov 29, 2023
commit ec2bb2f95b58ffe65fbf8ac102f41136c2afa0b7
28 changes: 16 additions & 12 deletions coderd/healthcheck/workspaceproxy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,22 @@ func TestWorkspaceProxies(t *testing.T) {
}
}

func TestWorkspaceProxy_ErrorDismissed(t *testing.T) {
t.Parallel()

var report healthcheck.WorkspaceProxyReport
report.Run(context.Background(), &healthcheck.WorkspaceProxyReportOptions{
WorkspaceProxiesFetchUpdater: &fakeWorkspaceProxyFetchUpdater{
fetchFunc: fakeFetchWorkspaceProxiesErr(assert.AnError),
updateFunc: fakeUpdateProxyHealth(assert.AnError),
},
Dismissed: true,
})

assert.True(t, report.Dismissed)
assert.Equal(t, health.SeverityWarning, report.Severity)
}

// yet another implementation of the thing
type fakeWorkspaceProxyFetchUpdater struct {
fetchFunc func(context.Context) (codersdk.RegionsResponse[codersdk.WorkspaceProxy], error)
Expand Down Expand Up @@ -236,15 +252,3 @@ func fakeUpdateProxyHealth(err error) func(context.Context) error {
return err
}
}

func TestWorkspaceProxy_Dismissed(t *testing.T) {
t.Parallel()

var report healthcheck.WorkspaceProxyReport
report.Run(context.Background(), &healthcheck.WorkspaceProxyReportOptions{
Dismissed: true,
})

assert.True(t, report.Dismissed)
assert.Equal(t, health.SeverityOK, report.Severity)
}