Skip to content

fix: track JetBrains connections #10968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 7, 2023
Merged

fix: track JetBrains connections #10968

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c9a226f
feat: implement jetbrains agentssh tracking
Emyrk Nov 30, 2023
2447970
Add unit test to confirm tracking
Emyrk Nov 30, 2023
76d3a24
implement unit test to verify jetbrains functionality
Emyrk Nov 30, 2023
adf2fb3
Implement port process inspection
code-asher Nov 30, 2023
ad034f2
Add JetBrains tracking to bottom bar
code-asher Dec 1, 2023
34b7c5e
Elaborate on process name check comment
code-asher Dec 1, 2023
dce56fd
Comment that localForwardChannelData is copied
code-asher Dec 1, 2023
7139448
Comment ChannelAccepterWatcher
code-asher Dec 1, 2023
6e8f235
Rename channel watcher to be specific to Jetbrains
code-asher Dec 1, 2023
4d65478
Log unmarshal failure
code-asher Dec 1, 2023
254a5b6
Add constant for JetBrains magic string
code-asher Dec 1, 2023
a75ed6c
Fix JetBrains tracking test
code-asher Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Elaborate on process name check comment 
Co-authored-by: Steven Masley <Emyrk@users.noreply.github.com>
  • Loading branch information
@code-asher @Emyrk
code-asher and Emyrk committed Dec 1, 2023
commit 34b7c5eb6003cf3667f64b6a229a254052f1636c
7 changes: 7 additions & 0 deletions agent/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,13 @@ func TestAgent_Stats_Magic(t *testing.T) {

// This test name must contain the string checked for by the agent, since it
// looks for this string in the process name.
//
// This test sets up a port forward that emulates what Jetbrains IDE's do when
// using gateway. The remote server side of the port forward is spun up using
// the gotest process, which includes the test name.
// So this unit test emulates a PID in the workspace with a similar
// name to the jetbrains IDE. That makes the agent this this SSH port
// forward is a "jetbrains" session.
t.Run("TracksIdea.vendor.name=JetBrains", func(t *testing.T) {
t.Parallel()
if runtime.GOOS != "linux" {
Expand Down