chore: deploy workspace proxies on fly.io #10983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
reviewed
Dec 1, 2023
deansheather
reviewed
Dec 4, 2023
Comment on lines
+804
to
+806
| TOKEN_PARIS: ${{ secrets.FLY_PARIS_CODER_PROXY_SESSION_TOKEN }} | ||
| TOKEN_SYDNEY: ${{ secrets.FLY_SYDNEY_CODER_PROXY_SESSION_TOKEN }} | ||
| TOKEN_SAO_PAULO: ${{ secrets.FLY_SAO_PAULO_CODER_PROXY_SESSION_TOKEN }} |
There was a problem hiding this comment.
fly.io doesn't have a way of adding secrets in their dashboard?
There was a problem hiding this comment.
They do have but I prefer we store all secrets in GitHub Actions. I can move if you disagree.
There was a problem hiding this comment.
If you use --env on the flyctl command does it store the secrets in plain text visible on the fly.io dashboard? If so then we should probably move them to secrets on fly.io instead of GH
There was a problem hiding this comment.
Fly.io has no environment section on the dashboard, so they do not appear anywhere.
deansheather
approved these changes
Dec 4, 2023
Co-authored-by: Dean Sheather <dean@deansheather.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new job called
deploy-wsproxiesthst is responsible for deploying the workspace proxies to the fly.io platform. The deployment is triggered only when the pull request is made from themainbranch.The
deploy-wsproxiesjob updates our workspaces proxies in 3 fly.io regionsThis pull request ensures that the proxies are up-to-date with
mainbtanch.