Skip to content

fix: use database for user creation to prevent flake #10992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 4, 2023
Merged

fix: use database for user creation to prevent flake #10992

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b862d50
fix: prevent flake by increasing context deadline
f0ssel Dec 1, 2023
859b6b6
use db over API to speed up user creation
f0ssel Dec 1, 2023
37a6c10
remove comments
f0ssel Dec 1, 2023
39cd0f7
remove comment
f0ssel Dec 1, 2023
d4d2317
use generics
f0ssel Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove comment
  • Loading branch information
@f0ssel
f0ssel committed Dec 1, 2023
commit 39cd0f7a2fea1af5fcee0696b21bf48d3fc00e52
1 change: 0 additions & 1 deletion coderd/users_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1866,7 +1866,6 @@ func assertPagination(ctx context.Context, t *testing.T, client *codersdk.Client
for i := range prevPage.Users {
require.Equalf(t, strings.ToLower(allUsers[count-limit : count][i].Username), strings.ToLower(prevPage.Users[i].Username), "prev users, offset=%d, limit=%d", count-limit, limit)
}
// require.Equal(t, allUsers[count-limit:count], prevPage.Users, "prev users")
count += len(page.Users)
}
}
Expand Down