Skip to content

fix: display app templates correctly in build preview #10994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 5, 2023
Merged

fix: display app templates correctly in build preview #10994

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1f4067
fix: appropriately display display_app apps in template build preview
Kira-Pilot Dec 1, 2023
3455992
added display apps to build preview
Kira-Pilot Dec 5, 2023
63f610b
added test, consolidated names
Kira-Pilot Dec 5, 2023
9fbab59
Merge remote-tracking branch 'origin/main' into preview-display-apps/…
Kira-Pilot Dec 5, 2023
8b65aa8
handling empty state
Kira-Pilot Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: appropriately display display_app apps in template build preview
  • Loading branch information
@Kira-Pilot
Kira-Pilot committed Dec 1, 2023
commit d1f4067e447b2283b7cc37f72abd7351b43fc256
15 changes: 12 additions & 3 deletions site/src/components/Resources/AgentRowPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { type FC } from "react";
import type { WorkspaceAgent } from "api/typesGenerated";
import { Stack } from "../Stack/Stack";
import { AppPreviewLink } from "./AppLink/AppPreviewLink";
import { DisplayApps, DisplayApp } from "api/typesGenerated";

interface AgentRowPreviewStyles {
// Helpful when there are more than one row so the values are aligned
Expand Down Expand Up @@ -86,9 +87,17 @@ export const AgentRowPreview: FC<AgentRowPreviewProps> = ({
spacing={0.5}
wrap="wrap"
>
{agent.apps.map((app) => (
<AppPreviewLink key={app.slug} app={app} />
))}
{/* display apps that are unconditionally shown, i.e. they are not included in the DisplayApp const array
or display apps that are conditionally shown (and appear in agent.display_apps) */}
{agent.apps
.filter(
(app) =>
!DisplayApps.includes(app.slug as DisplayApp) ||
agent.display_apps.includes(app.slug as DisplayApp),
)
.map((app) => (
<AppPreviewLink key={app.slug} app={app} />
))}
{agent.apps.length === 0 && (
<span css={styles.agentDataValue}>None</span>
)}
Expand Down