Skip to content

chore: Bump protoc to 3.20.0 #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2022
Merged

chore: Bump protoc to 3.20.0 #1104

merged 2 commits into from
Apr 23, 2022

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Apr 22, 2022

No description provided.

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to make gen too!

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1104 (ed5876d) into main (2a95917) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
- Coverage   66.53%   66.49%   -0.05%     
==========================================
  Files         255      255              
  Lines       15675    15743      +68     
  Branches      152      152              
==========================================
+ Hits        10430    10468      +38     
- Misses       4178     4201      +23     
- Partials     1067     1074       +7     
Flag Coverage Δ
unittest-go-macos-latest 53.30% <ø> (-0.11%) ⬇️
unittest-go-postgres- 65.93% <ø> (+0.04%) ⬆️
unittest-go-ubuntu-latest 55.84% <ø> (+<0.01%) ⬆️
unittest-go-windows-2022 53.00% <ø> (+0.17%) ⬆️
unittest-js 66.83% <ø> (ø)
Impacted Files Coverage Δ
codersdk/provisionerdaemons.go 59.70% <0.00%> (-5.98%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-4.81%) ⬇️
peer/conn.go 75.63% <0.00%> (-3.30%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
coderd/users.go 59.49% <0.00%> (-0.08%) ⬇️
coderd/httpmw/ratelimit.go 100.00% <0.00%> (ø)
coderd/provisionerdaemons.go 60.37% <0.00%> (ø)
coderd/coderdtest/coderdtest.go 98.87% <0.00%> (+<0.01%) ⬆️
coderd/coderd.go 97.35% <0.00%> (+0.04%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a95917...ed5876d. Read the comment docs.

@Emyrk
Copy link
Member Author

Emyrk commented Apr 22, 2022

True.

@Emyrk Emyrk enabled auto-merge (squash) April 23, 2022 01:41
@Emyrk Emyrk merged commit da36812 into main Apr 23, 2022
@Emyrk Emyrk deleted the stevenmasley/protoc_3.20 branch April 23, 2022 01:53
@kylecarbs
Copy link
Member

neato

@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants