feat(site): dismiss health section warnings #11059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
approved these changes
Dec 6, 2023
| const queryClient = useQueryClient(); | ||
| const healthSettingsQuery = useQuery(healthSettings()); | ||
| // They call the same mutation but are used in diff contexts so we don't want | ||
| // to merge their states |
There was a problem hiding this comment.
What edge cases were you running into by having just one mutation? I trust you, but I'm just curious, since the output looks so similar across each of the if branches
There was a problem hiding this comment.
Updated the comments to include a use case:
They call the same mutation but are used in diff contexts so we don't want
to merge their states. Eg. You dismiss a warning and when it is done it
will show the enable button but since the mutation is still invalidating
other queries it will be in the loading state when it should be idle.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-12-06.at.10.05.05.mov