Skip to content

feat(site): dismiss health section warnings #11059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 6, 2023
Merged

feat(site): dismiss health section warnings #11059

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
12302ad
Add dismiss/enable warnings into the health checks
BrunoQuaresma Dec 5, 2023
da70544
Add notification icon in the navbar
BrunoQuaresma Dec 6, 2023
ca11cd2
Fix storybook
BrunoQuaresma Dec 6, 2023
3ac588d
Merge branch 'main' of https://github.com/coder/coder into bq/add-dis…
BrunoQuaresma Dec 6, 2023
711ebee
Fix type
BrunoQuaresma Dec 6, 2023
dd722f6
Fix API call
BrunoQuaresma Dec 6, 2023
bf1f95a
Update comments
BrunoQuaresma Dec 6, 2023
a731a31
Merge branch 'main' of https://github.com/coder/coder into bq/add-dis…
BrunoQuaresma Dec 6, 2023
c22b453
Fix types
BrunoQuaresma Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comments
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Dec 6, 2023
commit bf1f95a5430eb61d253787b7d8447d76f0e8087f
4 changes: 3 additions & 1 deletion site/src/pages/HealthPage/DismissWarningButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ export const DismissWarningButton = (props: { healthcheck: HealthSection }) => {
const queryClient = useQueryClient();
const healthSettingsQuery = useQuery(healthSettings());
// They call the same mutation but are used in diff contexts so we don't want
// to merge their states
// to merge their states. Eg. You dismiss a warning and when it is done it
// will show the enable button but since the mutation is still invalidating
// other queries it will be in the loading state when it should be idle.
const enableMutation = useMutation(updateHealthSettings(queryClient));
const dismissMutation = useMutation(updateHealthSettings(queryClient));

Expand Down