refactor(site): improve minor queries and visuals on external auth #11066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kylecarbs @Emyrk just marking you to share a little bit of how we are organizing the queries and mutations |
Emyrk
reviewed
Dec 6, 2023
Parkreiner
approved these changes
Dec 6, 2023
| queryKey: ["external-auth", providerId, "device", deviceCode], | ||
| onSuccess: async () => { | ||
| // Force a refresh of the Git auth status. | ||
| await queryClient.invalidateQueries(["external-auth", providerId]); |
There was a problem hiding this comment.
I don't know what a good solution would be off the top of my head, but my main worry here is that onSuccess has been deprecated for useQuery in React Query v5, so I feel like we shouldn't become more dependent on that API, even though we can still technically use it in v4
There was a problem hiding this comment.
That is absolutely true! Let me remove it.
There was a problem hiding this comment.
After taking a look into this specific query, I think it is not trivial to remove it right now but we definitely can get back to this when migrating to v5.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS: To really improve the design of this, I would need to refactor the settings layout a bit which is out of the scope for now.
Before:
Now:
