feat(site): bring back dark blue #11071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
Dec 8, 2023
| @@ -32,7 +31,7 @@ export interface LicenseBannerViewProps { | |||
| warnings: string[]; | |||
| } | |||
|
|
|||
| export const LicenseBannerView: React.FC<LicenseBannerViewProps> = ({ | |||
| export const LicenseBannerView: FC<LicenseBannerViewProps> = ({ | |||
There was a problem hiding this comment.
Do you know of a way to get our linter to enforce this?
Kira-Pilot
reviewed
Dec 8, 2023
Kira-Pilot
approved these changes
Dec 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had feedback that some people miss the dark blue, and this is an easier first target for adding a theme switcher than light mode, so lets bring it back!
It's currently inaccessible, because it will need #11069 for persistence and another PR to actually introduce a setting for it to the app. This PR mostly exists to make that later PR more reviewable, by keeping its diff simpler.
Notable changes:
No more importing theme/colors! Colors need to be tweakable from theme to theme, and should be a part of the theme itself
Add
theme.colorsto replace the old globally importable module, and switch everyone overDuplicate theme/dark, with minor modifications, giving us theme/darkBlue
Actually fixes a minor visual bug where our buttons and inputs haven't been using Inter 💀
Some other small things snuck in because I never have any self control about those
Don't let the big line count scare you! Most of it is from moving/duplicating files without actually changing much!