Skip to content

fix: Add more golang types -> number ts type #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2022
Merged

fix: Add more golang types -> number ts type #1108

merged 1 commit into from
Apr 22, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Apr 22, 2022 •
edited
Loading

@f0ssel f0ssel requested review from kylecarbs and coadler April 22, 2022 20:46
@codecov
Copy link

codecov bot commented Apr 22, 2022 •
edited
Loading

Codecov Report

Merging #1108 (3080212) into main (d6c1c49) will increase coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
+ Coverage   66.37%   66.58%   +0.20%     
==========================================
  Files         252      255       +3     
  Lines       15559    15743     +184     
  Branches      152      152              
==========================================
+ Hits        10327    10482     +155     
- Misses       4177     4192      +15     
- Partials     1055     1069      +14
Flag Coverage Δ
unittest-go-macos-latest 53.39% <0.00%> (+0.07%) ⬆️
unittest-go-postgres- 65.88% <0.00%> (+0.01%) ⬆️
unittest-go-ubuntu-latest 56.14% <0.00%> (+0.17%) ⬆️
unittest-go-windows-2022 52.93% <0.00%> (?)
unittest-js 66.83% <ø> (ø)
Impacted Files Coverage Δ
scripts/apitypings/main.go 0.00% <0.00%> (ø)
coderd/httpapi/httpapi.go 66.25% <0.00%> (-6.25%) ⬇️
coderd/workspaceagents.go 59.62% <0.00%> (-2.97%) ⬇️
peer/channel.go 83.23% <0.00%> (-0.58%) ⬇️
pty/start_windows.go 66.95% <0.00%> (ø)
agent/usershell/usershell_windows.go 83.33% <0.00%> (ø)
pty/pty_windows.go 68.25% <0.00%> (ø)
provisionerd/provisionerd.go 80.14% <0.00%> (+1.17%) ⬆️
agent/agent.go 65.86% <0.00%> (+1.44%) ⬆️
peer/conn.go 79.44% <0.00%> (+1.52%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6c1c49...3080212. Read the comment docs.

@f0ssel f0ssel force-pushed the f0ssel/int-types branch from 6be45ef to 3080212 Compare April 22, 2022 20:51
@f0ssel f0ssel requested a review from a team as a code owner April 22, 2022 20:51
presleyp
presleyp approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@f0ssel f0ssel enabled auto-merge (squash) April 22, 2022 20:53
@f0ssel f0ssel merged commit e181007 into main Apr 22, 2022
@f0ssel f0ssel deleted the f0ssel/int-types branch April 22, 2022 21:01
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

@coadler coadler coadler approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
4 participants
@f0ssel @presleyp @coadler @misskniss