Skip to content

chore: check if process is nil #11090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2023
Merged

chore: check if process is nil #11090

merged 2 commits into from
Dec 7, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Dec 7, 2023

We check if process is nil in the ports_supported file. Just matching that defensive check, not sure if it can be nil.

Matching

coder/agent/ports_supported.go

Lines 52 to 54 in dbbf8ac

if tab.Process != nil {
procName = tab.Process.Name
}

@Emyrk
chore: check if process is nil
d364e86 
We check if process is nil in the ports_supported file.
Just matching that defensive check, not sure if it can be nil.
@Emyrk Emyrk requested a review from code-asher December 7, 2023 22:15
@Emyrk Emyrk enabled auto-merge (squash) December 7, 2023 22:22
@Emyrk Emyrk merged commit 8221544 into main Dec 7, 2023
@Emyrk Emyrk deleted the stevenmasley/match_listening_port_impl branch December 7, 2023 22:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @code-asher