feat(site): improve bulk delete flow #11093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix the test on Monday, but other than that, this is ready! |
| ), | ||
| ].map((url) => ( | ||
| <img key={url} alt="" aria-hidden css={{ ...visuallyHidden }} src={url} /> | ||
| )); |
There was a problem hiding this comment.
Use the loading attr as eadger would not work?
<img loading="eadger" src="..." />There was a problem hiding this comment.
we could add that to these to make sure it snags them, but the problem is that even if we put this on the images where they normally appear, they're not inserted in the DOM until the user is already supposed to be seeing them. the only way to make them load faster is to tell the browser about these images in advance.
BrunoQuaresma
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides more details about what you're actually doing, with some summaries and requiring multiple clicks, rather than just typing "DELETE" without any further detail
Screen.Recording.2023-12-08.at.4.11.53.PM.mov