chore: fix flake in TestExecutorAutostopTemplateDisabled #11096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a flake where the following can happen:
23:34:59.981
but ends at23:35:00.205
00:35:00.205
.created_at
instead of thecompleted_at
of the build so we get00:35:59.981
which truncates down to00:35:00
which is less than the deadline.I've gone ahead and fixed it but we should maybe reconsider whether this test should exist in
autobuild
since it's really testing that the deadline is set correctly inprovisionerdserver
. We can't really refactor this test withdbfake
without completely obviating what it's trying to test.fixes #10359